Keep the best block built until now instead of the last one #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
changed the title
Signed-off-by: Fabio Di Fabio <[email protected]>
jflo
approved these changes
Sep 29, 2022
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 5, 2022
…ger#4455) Signed-off-by: Fabio Di Fabio <[email protected]>
jflo
added a commit
that referenced
this pull request
Oct 5, 2022
* Change min selection to an unsigned min (#4420) Change the "minimum" gas in the TangerineWhistleGasCalculator to use an unsigned comparison, to ensure a larger signed value is not selected. Signed-off-by: Danno Ferrin <[email protected]> * Update Security Policy contact info (#4447) * Update Security Policy contact info At the request of the EF, a besu-only security list was created, and is the first listed email. The out-of-date Jira location is also removed. Signed-off-by: Danno Ferrin <[email protected]> * Keep the best block built until now instead of the last one (#4455) Signed-off-by: Fabio Di Fabio <[email protected]> * Add Mainnet to merged networks (#4463) * Add Mainnet to the merged networks, to force fast-sync-min-peers to 1 Signed-off-by: Fabio Di Fabio <[email protected]> * Avoid to process transactions during initial sync (#4457) Signed-off-by: Fabio Di Fabio <[email protected]> * uprev version to 22.7.5 Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ger#4455) Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio [email protected]
PR description
If the consensus layer client, send more than once the same forkchoice update with payload attributes, we build more blocks with the same payload id, but the current implementation just keep the latest one built, no matter if it is better or not than the existing ones.
This PR improve that, comparing the blocks with the same payload id, and keeping the best according to the amount of gas used, this could be improved in a next iteration, comparing the actual fee reward of the block.
Fixed Issue(s)
fixes #4401
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog